| Topic: | Fix for NewUser / back button problem |
|---|---|
|
ccandreva
Helper
Posts: 145 Posted: |
I've patched my NewUser/user.php to solve the problem of users being told to hit the back button after an error, but the form not working at that point. Instead of displaying just a static error, the registration form is redisplayed with the error at the top. This seemed like a simple solution, but I couldn't find any discussion of this since Jan. I'm perfectly willing to submit this as a patch, unless there is an obvious reason I've missed why this hasn't been done ? -Chris |
|
ccandreva
Helper
Posts: 145 Posted: |
I've submitted this patch. Feedback is appreciated. |
|
tracedog
Softmore
Posts: 89 Posted: |
I could not get this to work. The user.php resulting page came back with code instead of the true display. I do like the idea - will monitor to see if there is any other feedback. |
|
ccandreva
Helper
Posts: 145 Posted: |
Odd. Do you have a test site with that version running, so I can see the results ? Alternatively, send me the user.php that resulting from the patch. chris at westnet dot com |
|
ccandreva
Helper
Posts: 145 Posted: |
Has anyone else tried this patch with good/bad results ? Is there anything else I should do to get it incorporated in SVN ? |
|
larsneo
Software Foundation
Posts: 4482 Posted: |
please check the .8 way of checking forms with some client-side-javascript: http://pn8.pn-cms.de/index.php?module=Users&func=register -- regards from germany ..::[Zikula Application Framework]::.. ..::[SEO-Blog]::.. ..::[CMS Sicherheit]::.. |
|
ccandreva
Helper
Posts: 145 Posted: |
Interesting, and it degrades nicely if javascript is turned off. While back now works, having to hit Back from an error is still clunky. I would think redisplaying the form with the error would be preferable in the case that JavaScript wasn't available. With the JavaScript version, I would also think it should be possible to have just a single button that checks, and if everything is ok does the submit. Again, having two buttons seems clunky, but this isn't the forum. In any case, I don't think trying to port the Ajax stuff into 0.76x is worthwhile, so this is a simple fix for anyone who wants it. I would like to know what problem tracedog had. |