Zikula: A Flexible Open Source Content Management System
home | forum | contact us

Dizkus

Bottom
Fix for NewUser / back button problem
  • Posted: 12.07.2006, 06:33
     
    ccandreva
    rank:
    Helper Helper
    registered:
     September 2005
    Status:
    offline
    last visit:
    18.09.08
    Posts:
    145
    I've patched my NewUser/user.php to solve the problem of users being told to hit the back button after an error, but the form not working at that point. Instead of displaying just a static error, the registration form is redisplayed with the error at the top.

    This seemed like a simple solution, but I couldn't find any discussion of this since Jan. I'm perfectly willing to submit this as a patch, unless there is an obvious reason I've missed why this hasn't been done ?

    -Chris
  • Posted: 22.07.2006, 00:24
     
    ccandreva
    rank:
    Helper Helper
    registered:
     September 2005
    Status:
    offline
    last visit:
    18.09.08
    Posts:
    145
    I've submitted this patch. Feedback is appreciated.
  • Posted: 25.07.2006, 06:40
     
    tracedog
    rank:
    Softmore Softmore
    registered:
     April 2005
    Status:
    offline
    last visit:
    15.01.07
    Posts:
    89
    I could not get this to work. The user.php resulting page came back with code instead of the true display. I do like the idea - will monitor to see if there is any other feedback.
  • Posted: 25.07.2006, 07:33
     
    ccandreva
    rank:
    Helper Helper
    registered:
     September 2005
    Status:
    offline
    last visit:
    18.09.08
    Posts:
    145
    Odd. Do you have a test site with that version running, so I can see the results ? Alternatively, send me the user.php that resulting from the patch. chris at westnet dot com

  • Posted: 08.09.2006, 06:12
     
    ccandreva
    rank:
    Helper Helper
    registered:
     September 2005
    Status:
    offline
    last visit:
    18.09.08
    Posts:
    145
    Has anyone else tried this patch with good/bad results ?

    Is there anything else I should do to get it incorporated in SVN ?
  • Posted: 08.09.2006, 12:05
     
    larsneo
    rank:
    Software Foundation Software Foundation
    registered:
     December 1969
    Status:
    offline
    last visit:
    15.11.08
    Posts:
    4481
    please check the .8 way of checking forms with some client-side-javascript: http://pn8.pn-cms.de/index.php?module=Users&func=register


    --
    regards from germany
    ..::[Zikula Application Framework]::.. ..::[SEO-Blog]::.. ..::[CMS Sicherheit]::..
  • Posted: 08.09.2006, 19:58
     
    ccandreva
    rank:
    Helper Helper
    registered:
     September 2005
    Status:
    offline
    last visit:
    18.09.08
    Posts:
    145
    Interesting, and it degrades nicely if javascript is turned off. While back now works, having to hit Back from an error is still clunky. I would think redisplaying the form with the error would be preferable in the case that JavaScript wasn't available.

    With the JavaScript version, I would also think it should be possible to have just a single button that checks, and if everything is ok does the submit. Again, having two buttons seems clunky, but this isn't the forum.

    In any case, I don't think trying to port the Ajax stuff into 0.76x is worthwhile, so this is a simple fix for anyone who wants it. I would like to know what problem tracedog had.

Main Menu

Extensions Database

Documentation

Development

Login

Donate to Zikula